Add skipValidation support to find and update methods
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pl217
added
the
ready for review
krishnareddy-tadi
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support UN-OCHA/hpc-api#94
This PR adds
skipValidationoption forfindandupdatemethods of our models. This feature skips data validation that we do with ourio-tscodecs. It should be used very rarely!We've seen some endpoints suffer from significant slowdowns (like in UN-OCHA/hpc-api#94) due to data validation and it takes a significant portion of time to complete the query. For example, when fetching attachments by their IDs, data fetching takes 20-25% of time, while validation takes 75-80% of time, which can be a huge burden, causing timeouts of our APIs.