Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce getConditionFieldsForProjects #57

Merged
merged 3 commits into from
Dec 2, 2021
Merged

✨ Introduce getConditionFieldsForProjects #57

merged 3 commits into from
Dec 2, 2021

Conversation

s0
Copy link
Contributor

@s0 s0 commented Nov 25, 2021 •
edited
Loading

This supports HPC-6264

(this will cause type-error conflict with #66, so whichever is merged last will need to be rebased and fixed)

@s0 s0 requested a review from a team as a code owner November 25, 2021 18:39
@Pl217 Pl217 assigned s0 Nov 26, 2021
@s0 s0 assigned czmj and Pl217 and unassigned s0 Dec 2, 2021
@s0 s0 added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed needs rebase labels Dec 2, 2021
Pl217
Pl217 reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to make these changes in two separate commits, because changes are pretty different. In first commit, extend getAllProjectsForPlan and in second commit introduce getConditionFieldsForProjects

src/lib/data/projects.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 assigned s0 and unassigned Pl217 Dec 2, 2021
@s0 s0 assigned Pl217 and unassigned s0 Dec 2, 2021
@s0 s0 added ready for review All comments have been addressed, and the Pull Request is ready for review and removed ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. labels Dec 2, 2021
@s0 s0 mentioned this pull request Dec 2, 2021
Merged
s0 added 3 commits December 2, 2021 18:51
@s0
✨ Extend getAllProjectsForPlan to also return projectVersionPlan
490b3bc
@s0
✨ Introduce getConditionFieldsForProjects
fd36387
@s0
✨ Allow for more flexible use of project lib module
e11b929 
To allow for code that has retreived projects in a different manner to
use the utility functions for loading project data, only require the
needed data to be supplied.
@s0
Copy link
Contributor Author

s0 commented Dec 2, 2021 •
edited
Loading

Rebased ontop of develop now #66 is merged, this is ready for review now.

No need to bump the version with this one, as there is a bit more work that is still needed for UN-OCHA/hpc_service#2514

@Pl217 Pl217 merged commit 89b55db into develop Dec 2, 2021
@Pl217 Pl217 deleted the HPC-6264 branch December 2, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 approved these changes

Assignees

@czmj czmj

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s0 @Pl217 @czmj