✨ HPC-8267: Introduce getProjectBudgetsByOrgAndCluster #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an up-to-date implementation of getProjectBudgetsByOrg from hpc_service, which uses all the latest coding practices for the project. Once this has been merged and is usable, getProjectBudgetsByOrg will be updated to be implemented using this new function.
s0
added
the
ready for review
Pl217
approved these changes
Dec 2, 2021
| const segments = segmentsByProjectVersion.get(p.projectVersion.id); | ||
|
|
||
| // Handle $0 projects with no budget segments | ||
| if (!segments && p.projectVersion.currentRequestedFunds === '0') { |
There was a problem hiding this comment.
Too bad we aren't ready to use BigInt here and also below where you do if (sum.toString() !== p.projectVersion.currentRequestedFunds). We cannot even convert p.projectVersion.currentRequestedFunds into BigInt, because we cannot compare to 0n literal, since our compilation target is lower than ES2020.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports https://github.com/UN-OCHA/hpc_service/pull/2514
This is an up-to-date implementation of getProjectBudgetsByOrg from
hpc_service, which uses all the latest coding practices for the project.
Once this has been merged and is usable, getProjectBudgetsByOrg will be updated in https://github.com/UN-OCHA/hpc_service/pull/2514 to be implemented using this new function.