Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to hidId #80

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Remove references to hidId #80

merged 3 commits into from
Jun 15, 2022

Conversation

czmj
Copy link
Contributor

@czmj czmj commented Feb 2, 2022

No description provided.

@czmj czmj requested a review from a team as a code owner February 2, 2022 14:10
@czmj czmj added the ready for review All comments have been addressed, and the Pull Request is ready for review label Feb 2, 2022
Pl217
Pl217 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but let's not merge until needed

@Pl217 Pl217 removed their assignment Apr 4, 2022
@Pl217 Pl217 added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Apr 4, 2022
Pl217
Pl217 requested changes Apr 7, 2022
View reviewed changes
src/auth/index.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 added needs minor changes There are review or issue comments to address and removed ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. labels Apr 7, 2022
@Pl217 Pl217 added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed needs minor changes There are review or issue comments to address labels Jun 15, 2022
@Pl217 Pl217 assigned Pl217 and unassigned czmj Jun 15, 2022
@Pl217 Pl217 merged commit 92e7878 into develop Jun 15, 2022
@Pl217 Pl217 deleted the HPC-8127 branch June 15, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 approved these changes

Assignees

@Pl217 Pl217

Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czmj @Pl217