BXC-4429 update based on PR comments

UNC-Libraries · Feb 26, 2024 · ec0aeda · ec0aeda
1 parent fb6d9de
commit ec0aeda
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...es-app/src/main/java/edu/unc/lib/boxc/web/services/rest/modify/ViewSettingController.java b/...es-app/src/main/java/edu/unc/lib/boxc/web/services/rest/modify/ViewSettingController.java
@@ -80,7 +80,7 @@ public ResponseEntity<Object> getViewSetting(@PathVariable("id") String id) {
     public ResponseEntity<Object> updateViewSetting(@RequestParam Map<String,String> allParams) {
         Map<String, Object> result = new HashMap<>();
 
-        if (badParams(allParams)) {
+        if (hasBadParams(allParams)) {
             result.put("error", "Request must include ids and view settings");
             return new ResponseEntity<>(result, HttpStatus.BAD_REQUEST);
         }
@@ -128,13 +128,13 @@ private String getValue(Resource resource, Property property) {
     }
 
     private ViewSettingRequest buildRequest(String id, ViewSettingRequest.ViewBehavior viewBehavior) {
-        var request = new ViewSettingRequest();;
+        var request = new ViewSettingRequest();
         request.setObjectPidString(id);
         request.setViewBehavior(viewBehavior);
         return request;
     }
 
-    private boolean badParams(Map<String,String> params) {
+    private boolean hasBadParams(Map<String,String> params) {
         return params.isEmpty() || StringUtils.isBlank(params.get("targets"));
     }
 }