Bxc 4375 refactor image server proxy #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
requested changes
Dec 12, 2023
...ices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/ImageServerProxyService.java
Outdated
Show resolved
Hide resolved
...ices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/ImageServerProxyService.java
Outdated
Show resolved
Hide resolved
...ices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/ImageServerProxyService.java
Outdated
Show resolved
Hide resolved
...ervices-app/src/main/java/edu/unc/lib/boxc/web/services/rest/ImageServerProxyController.java
Outdated
Show resolved
Hide resolved
bbpennel
reviewed
Dec 12, 2023
| LOG.debug("Access was forbidden to {} for user {}", id, GroupsThreadStore.getUsername()); | ||
| response.setStatus(HttpStatus.FORBIDDEN.value()); | ||
| AccessGroupSet principals = getAgentPrincipals().getPrincipals(); | ||
| accessControlService.assertHasAccess("Insufficient permissions to metadata for " + id, |
There was a problem hiding this comment.
I guess this message isn't really accurate for a request to get a jpg region
There was a problem hiding this comment.
hehe whoops! fixed this and the missing word for the actual get metadata endpoint
bbpennel
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new tests and refactors the image server proxy code to more clearly separate the controller and service. This also affected some downloadImage code to use new Util code.
https://unclibrary.atlassian.net/browse/BXC-4375