Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BXC-4470 - De-Lorisify iiif v2 implementation #1682

Merged
merged 4 commits into from
Feb 21, 2024
Merged

BXC-4470 - De-Lorisify iiif v2 implementation #1682

merged 4 commits into from
Feb 21, 2024

Conversation

bbpennel
Copy link
Member

https://unclibrary.atlassian.net/browse/BXC-4470

  • Remove all Loris references, renaming to IIIF v2 theme
  • Move iiif v2 endpoint from access app to services, since that is where v3 resides
  • Change URL pattern for iiif v2 to match v3's
  • Removes iiif v2 manifest integration test, which is mostly covered by a unit test now (test coverage is definitely not 100% for the v2 implementation, but wasn't before either)
  • Remaps "full/full" jp2 region requests to "full/max" since cantaloupe iiif v2 doesn't appear to be able to handle "full/full" even though that is what is in the v2 iiif spec.
  • iiif related property names now specify v2 or v3

@bbpennel
Switch iiif v2 endpoints and services from loris to cantaloupe. Move …
07926f2 
…api endpoint to services. Remove unused properties and parameters
@bbpennel
Delete the integration test for v2 manifests since that is no longer …
f34a4fe 
…in the access app. Add a basic unit test for v2 manifest generation controller. Some tidying up
@bbpennel
Remove unused test code
6c647b5
sharonluong
sharonluong requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@sharonluong sharonluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small things

@sharonluong sharonluong merged commit d56cd4f into main Feb 21, 2024
3 of 5 checks passed
@bbpennel bbpennel deleted the bxc-4470-iiifv2 branch February 21, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharonluong sharonluong sharonluong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbpennel @sharonluong