Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][BF] dcm2bids_helper #161

Merged
merged 5 commits into from
Apr 19, 2022
Merged

[WIP][BF] dcm2bids_helper #161

merged 5 commits into from
Apr 19, 2022

Conversation

arnaudbore
Copy link
Contributor

Fix #160

@arnaudbore arnaudbore requested a review from SamGuay April 19, 2022 13:05
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the ways I could think of to make it crash and it didn't!

I suggest that we change -f to --force just because it's less risky to run it by chance.

dcm2bids/helper.py Outdated Show resolved Hide resolved
dcm2bids/helper.py Outdated Show resolved Hide resolved
dcm2bids/utils.py Outdated Show resolved Hide resolved
dcm2bids/utils.py Outdated Show resolved Hide resolved
arnaudbore and others added 4 commits April 19, 2022 15:43
Co-authored-by: Samuel Guay <[email protected]>
Co-authored-by: Samuel Guay <[email protected]>
Co-authored-by: Samuel Guay <[email protected]>
Co-authored-by: Samuel Guay <[email protected]>
@arnaudbore arnaudbore merged commit 754a5bd into master Apr 19, 2022
@arnaudbore arnaudbore deleted the BF_dcm2bids_helper branch May 30, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use --forceDcm2niix option with dcm2bids_helper
2 participants