Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post op - pydeface #260

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Fix post op - pydeface #260

merged 9 commits into from
Sep 12, 2023

Conversation

arnaudbore
Copy link
Contributor

This PR should fix this issue #258

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -2.36% ⚠️

Comparison is base (cb4bdb8) 78.60% compared to head (89e3fbb) 76.25%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   78.60%   76.25%   -2.36%     
==========================================
  Files          15       15              
  Lines        1019     1057      +38     
  Branches      217      232      +15     
==========================================
+ Hits          801      806       +5     
- Misses        171      203      +32     
- Partials       47       48       +1     
Flag Coverage Δ
pytest 76.25% <20.00%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dcm2bids/sidecar.py 81.01% <0.00%> (-0.52%) ⬇️
dcm2bids/acquisition.py 77.24% <6.89%> (-16.78%) ⬇️
dcm2bids/dcm2bids_gen.py 76.34% <50.00%> (-4.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnaudbore arnaudbore mentioned this pull request Sep 10, 2023
@SamGuay SamGuay merged commit de8d37e into master Sep 12, 2023
@arnaudbore arnaudbore deleted the fix_post_op branch September 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants