Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow disable automatic reorder entities #303

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

arnaudbore
Copy link
Contributor

Quite some time we've been asked to add this feature:
Using: --do_not_reorder_entities users can now order the custom_entities the way they want to.

@arnaudbore arnaudbore requested a review from SamGuay June 27, 2024 15:51
@arnaudbore arnaudbore changed the base branch from master to dev June 27, 2024 15:55
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded the help but otherwise seems good. However, I see no unit test for this option as of now?

dcm2bids/cli/dcm2bids.py Outdated Show resolved Hide resolved
@SamGuay SamGuay merged commit 6fc1fdf into dev Jul 17, 2024
28 checks passed
@arnaudbore arnaudbore deleted the allow_disable_reorder branch July 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants