Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to EMIT app in the Large Methane Emissions data insight #381

Merged
merged 3 commits into from
May 15, 2024

Conversation

binni979
Copy link

@binni979 binni979 commented May 13, 2024

This is the pull request to solve this issue - #374

Approaches:
Changed the a href="https://nasa-impact.github.io/interactive-emission-plumes/" target="_blank" rel="noopener" to /data-catalog/emit-ch4plume-v1 in the discovering-large-methane-emissions-stories.mdx file.

@binni979 binni979 requested a review from slesaad May 13, 2024 18:56
Copy link

netlify bot commented May 13, 2024

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit 47c93f4
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/6643e009aced270009391280
😎 Deploy Preview https://deploy-preview-381--ghg-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@binni979 binni979 self-assigned this May 13, 2024
@slesaad
Copy link
Collaborator

slesaad commented May 13, 2024

can you remove the target and rel so it opens in the same tab?

@slesaad slesaad linked an issue May 13, 2024 that may be closed by this pull request
1 task
@slesaad slesaad changed the title Worked on link to methane plumes viewer problem Update link to EMIT app in the Large Methane Emissions data insight May 13, 2024
@slesaad slesaad merged commit e5d6cce into develop May 15, 2024
5 checks passed
@slesaad slesaad deleted the link-methan-plumes branch May 15, 2024 13:33
@slesaad slesaad mentioned this pull request May 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to methane plumes viewer should open embedded app, not full-screen
2 participants