Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DatabaseHandler::insert_or_update_profiles and test #14

Conversation

couryrr-afs
Copy link

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Copy link

@christopher-davis-afs christopher-davis-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, but otherwise LGTM.

Signed-off-by: Coury Richards <[email protected]>
Copy link

@christopher-davis-afs christopher-davis-afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that this doesn't update the status doc but does tackle a functional requirement.

@couryrr-afs
Copy link
Author

Just realized that this doesn't update the status doc but does tackle a functional requirement.

@christopher-davis-afs I was holding off marking that until we get the full boot call completed.

@christopher-davis-afs christopher-davis-afs merged commit 6845f80 into feature/k01-porting-database May 7, 2024
2 checks passed
@couryrr-afs couryrr-afs deleted the couryrr/K01.FR27-persiste-profiles branch June 12, 2024 19:56
@couryrr-afs couryrr-afs restored the couryrr/K01.FR27-persiste-profiles branch June 12, 2024 19:57
@couryrr-afs couryrr-afs deleted the couryrr/K01.FR27-persiste-profiles branch June 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants