Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kick off different webpack build configs for dev vs prod #389

Merged
merged 1 commit into from
Oct 2, 2018
Merged

kick off different webpack build configs for dev vs prod #389

merged 1 commit into from
Oct 2, 2018

Conversation

lindsayplatt
Copy link

@lindsayplatt lindsayplatt commented Oct 2, 2018 •
edited
Loading

Tested this with gage-conditions. The dev bundle.js was 1.2 MB and the beta bundle.js was 250 KB.

vizlab::vizmake(webpack_build_cfg = "dev") # uses webpack --mode development
vizlab::vizmake(webpack_build_cfg = "beta") # uses webpack --mode production

aappling-usgs
aappling-usgs approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@aappling-usgs aappling-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is really exciting.

@aappling-usgs aappling-usgs merged commit f253864 into USGS-VIZLAB:master Oct 2, 2018
@mwernimont
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aappling-usgs aappling-usgs aappling-usgs approved these changes

@mwernimont mwernimont Awaiting requested review from mwernimont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindsayplatt @mwernimont @aappling-usgs