fix: Fix login success redirect status (#542)

* Fix login success redirect status * Update login test
USSF-ORBIT · Mar 2, 2022 · 17b31ee · 17b31ee
1 parent d927a1b
commit 17b31ee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/__tests__/pages/api/auth/[[...action]].test.ts b/src/__tests__/pages/api/auth/[[...action]].test.ts
@@ -88,7 +88,7 @@ describe('API / Auth handlers', () => {
         url: '/api/auth/login',
         test: async ({ fetch }) => {
           const res = await fetch({ method: 'POST', redirect: 'manual' })
-          expect(res.status).toBe(307)
+          expect(res.status).toBe(302)
           expect(res.cookies).toStrictEqual([
             expect.objectContaining({ sid: expect.any(String) }),
           ])

diff --git a/src/pages/api/auth/[[...action]].ts b/src/pages/api/auth/[[...action]].ts
@@ -48,10 +48,13 @@ handler.get('/api/auth/login', passport.authenticate('saml'))
 handler.post(
   '/api/auth/login',
   passport.authenticate('saml', {
-    successRedirect: '/',
     failureRedirect: '/login',
     failureMessage: true,
-  })
+  }),
+  function (req, res) {
+    // Login was successful, redirect back home
+    res.redirect(302, '/')
+  }
 )
 
 //  GET /api/auth/logout - initiate a SLO (logout) request