feat: Add hero image support for landing page #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2636: Image and video support for landing page hero or badge. |
|
Looks good! |
gidjin
reviewed
Jan 12, 2024
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const pageContent = (): any => { | ||
| return ( | ||
| <> | ||
| <h1 className={styles.pageTitle}>{pageTitle}</h1> | ||
| <div className={styles.pageTitleContainer}> |
There was a problem hiding this comment.
Thought(non-blocking): I wonder if we should refactor this so that most of pageContent function is in a separate component so that we can display it in storybook. I don't think this needs to happen now though since the page is already not in storybook. Probably we should come to some sort of consensus on this type of thing, maybe next design eng sync.
gidjin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-2636
Proposed changes
Should be merged after https://github.com/USSF-ORBIT/ussf-portal-cms/pull/417
Reviewer notes
You will need the accompanying CMS branch in order for this to work.
Testing is straightforward:
E2E tests:
https://github.com/USSF-ORBIT/ussf-portal/pull/350
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots