Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update node to LTS #1229

Merged
merged 1 commit into from
Mar 27, 2024
Merged

chore: Update node to LTS #1229

merged 1 commit into from
Mar 27, 2024

Conversation

spardue
Copy link
Contributor

@spardue spardue commented Mar 25, 2024

SC-423

Proposed changes

Update Node to LTS


Reviewer notes

Setup

Start the system

yarn services:up
yarn dev
cd ../ussf-portal-cms
yarn dev

Login to the portal http://localhost:3000

Start storybook

yarn storybook

Login to storybook http://localhost:6006, though the command above should open it for you


Code review steps

As the original developer, I have

  • Met the acceptance criteria
  • Created new stories in Storybook if applicable
  • Created/modified automated unit tests in Jest
  • Created/modified automated E2E tests
  • Followed guidelines for zero-downtime deploys, if applicable
  • Use ANDI to check for basic a11y issues

As a reviewer, I have

Check out our How to review a pull request document.


Screenshots

@spardue spardue requested a review from a team as a code owner March 25, 2024 20:05
@spardue spardue changed the title Update node to LTS chore: Update node to LTS Mar 26, 2024
@spardue spardue force-pushed the chore/update_to_node_lts branch from 507c899 to 75be007 Compare March 26, 2024 18:57
@spardue spardue requested a review from natem11 March 26, 2024 19:23
@spardue spardue merged commit 3fdc2d1 into main Mar 27, 2024
11 checks passed
@spardue spardue deleted the chore/update_to_node_lts branch March 27, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants