Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show "Downgrade" instead of "Upgrade" when versionString < installedVersionString #26

Closed

Conversation

PeterNerlich
Copy link

@bhdouglass
Copy link
Member

Thanks for the contribution! Unfortunately just checking the version string isn't enough as we use revisions to check for updates. I believe in this case, when the apps is from outside the OpenStore, the revision of the installed app will be 0.

@bhdouglass
Copy link
Member

Also, can you leave out the updates to the po files? I should probably fix that to be relative

@PeterNerlich
Copy link
Author

Ha, I didn't expect this to go through being so easy, so no worries :3
Still, I think there should be an easier way to check whether to show upgrade or downgrade. Maybe it's already enough comparing the revision numbers for that and just show something like "replace" for those with 0 or only use the version string in this case? Anyway, I regard this as important, since it seems to me that quite some people already fell for that, mistaking it for a genuine upgrade.

@bhdouglass
Copy link
Member

It probably makes sense to show the button as "replace" or something and also have a warning as to why we want to replace it.

@bhdouglass
Copy link
Member

I'm going to close this since its very old and doesn't follow the update checking that we currently have in place. Feel free to open another pull request if changes are made to use revisions rather than version numbers.

@bhdouglass bhdouglass closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants