Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uart more robust - add start byte, add crc check. #1095

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kareltucek
Copy link
Collaborator

@kareltucek kareltucek commented Jan 16, 2025

Changes:

  • decrease uart timeouts, but at the same time forgive one missed ping
  • check consistency of uart messages
  • start message frames explicitly, thus reducing issues with interference where a single spike can shift the entire message by a byte.
  • reset the link protocol when an inconsistent uart message is received

This PR should solve:

  • lags when the bridge cable is connected
  • some of the key chatter and stucking

(Reseting the entire link is hardly ideal, and later should be replaced by a more robust solution.)

@kareltucek kareltucek force-pushed the uart_reliability branch 2 times, most recently from b84c6db to 380f2db Compare January 26, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant