Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

issue-64: Changes max_length for LogEntry.path #65

Merged
merged 4 commits into from
Nov 18, 2020

Conversation

lowitea
Copy link
Contributor

@lowitea lowitea commented Nov 18, 2020

closes #64

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #65 (0ace41a) into develop (9562a22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #65   +/-   ##
========================================
  Coverage    98.33%   98.33%           
========================================
  Files            5        5           
  Lines          120      120           
  Branches         4        4           
========================================
  Hits           118      118           
  Misses           2        2           
Impacted Files Coverage Δ
http_stubs/models.py 96.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9562a22...0ace41a. Read the comment docs.

@lowitea lowitea self-assigned this Nov 18, 2020
@lowitea lowitea added the bug Something isn't working label Nov 18, 2020
@lowitea lowitea added this to the 0.1.6 milestone Nov 18, 2020
client.post('/default_path/', 'test', content_type=content_type)
http_body = http_stub_factory(
method=HTTPMethod.POST.name,
path='/regex/.*',
Copy link
Collaborator

@emorozov emorozov Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: .* part in the regexp is unnecessary: regexp /regex/ will match same set of inputs as /regex/.* but will do it more efficiently as no time would be wasted for searching for the throwaway .* part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right) Thank you. Fixed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lowitea lowitea merged commit d9b93b6 into Uma-Tech:develop Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: value too long for type character in LogEntry.path
2 participants