Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl WithdrawMargin message #628

Merged
merged 4 commits into from
Jun 25, 2023
Merged

Impl WithdrawMargin message #628

merged 4 commits into from
Jun 25, 2023

Conversation

taiki1frsh
Copy link
Collaborator

close #618

  • Enable the owner of the position to withdraw part of the margin as long as the remaining margin doesn't go under liquidation condition
  • If updated remaining margin needs to be liquidation, then the tx fails.

@Senna46
Copy link
Contributor

Senna46 commented Jun 25, 2023

The same changes are included. I changed the base branch.

@Senna46 Senna46 changed the base branch from newDevelop to feature/add-margin-to-any-positions June 25, 2023 11:01
@Senna46
Copy link
Contributor

Senna46 commented Jun 25, 2023

Once merged, we will discuss at #625

@Senna46 Senna46 merged commit 23c9281 into feature/add-margin-to-any-positions Jun 25, 2023
@Senna46 Senna46 deleted the feature/withdraw-margin branch June 25, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senna46 Senna46 Senna46 approved these changes

@kimurayu45z kimurayu45z Awaiting requested review from kimurayu45z

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[derivatives] Add Msg to partially withdraw margin on position
2 participants
@taiki1frsh @Senna46