Bugfix upon restart #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.] This bug creates problem only under these circumstances: if someone activates the diffusive temperature at the beginning of the simulation/ if someone is activating the lithostatic pressure flag. -> If you the simulation is restarted, the temperature diffusion step is repeat at the beginning of the restarting simulation, as well as for the lithostatic pressure. => Since the lithostatic pressure is substituting the actual pressure field for the computation, this invalidates a bit the restarted simulation. Same reasoning can be applied with the temperature diffusive timestep.
Just checking now if it works
boriskaus
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1] If the steady state temperature field, the diffusion temperature time step, or the initial lithostatic pressure are activated, they are performed also after restarting the simulation:
a.) This implies that the vector of pressure from the restart database is overwritten by the guess of lithostatic pressure (=BAD).
b.) This implies that the current temperature field coming from the restart database will be modified.
2] This PR introduces a solution:
-> TSSolve is an argument of these function: if the timestep is different than 0, these function are not applied.