Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button on option detail pages is broken #77

Closed
stevenzeck opened this issue Apr 25, 2018 · 5 comments
Closed

Edit button on option detail pages is broken #77

stevenzeck opened this issue Apr 25, 2018 · 5 comments
Assignees
Labels

Comments

@stevenzeck
Copy link
Contributor

stevenzeck commented Apr 25, 2018

  • Individual option detail page
  • Individual language page
  • Individual beautifier page

screen shot 2018-04-25 at 11 09 13 am

@Glavin001
Copy link
Member

Reproduce

Go to https://unibeautify.com/docs/option-align-assignments.html
Edit button goes to https://github.com/unibeautify/website/edit/master/docs/option-align-assignments.md

Analysis

Looking at the applicable code: https://github.com/Unibeautify/website/blob/master/scripts/generate-docs/OptionsDoc.ts#L57-L59
The edit button should go to https://github.com/unibeautify/unibeautify/edit/master/src/options.ts

This indicates to me Docusaurus is not respecting the changes from my PR. Maybe the version does not include my changes?

From 30b5476

image

Looking at versions from https://www.npmjs.com/package/docusaurus

1.0.9 a month ago

My PR was well over a month ago: facebook/docusaurus#443

Do we need facebook/docusaurus#604 to be published?

🔥 I'm confused 🔥

Will debug more later tonight.

@Glavin001 Glavin001 added the bug label Apr 25, 2018
@stevenzeck
Copy link
Contributor Author

stevenzeck commented Apr 25, 2018

@Glavin001 it broke with a later commit in Docusaurus. It will be fixed when facebook/docusaurus#604 is released. For now pin to 1.0.10.

@Glavin001
Copy link
Member

Awesome work, @szeck87 !

I suppose this bug should really be third-party-bug 😉. Glad it's figured out.

@Glavin001
Copy link
Member

Will be fixed as part of #76

Glavin001 added a commit that referenced this issue May 3, 2018
Fix #77. Update Docusaurus to fix edit buttons
@Glavin001
Copy link
Member

#76 is taking too long. Fixed as part of #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants