Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store grid mapping on metpy_crs coord rather than DataArray attrs in GEMPAK reader #2066

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Store grid mapping on metpy_crs coord rather than DataArray attrs in GEMPAK reader #2066

merged 2 commits into from
Sep 16, 2021

Conversation

jthielen
Copy link
Collaborator

Description Of Changes

Simple change to GempakGrid.gdxarray() to store grid mapping on metpy_crs coord rather than DataArray attrs (as discussed in #2046). A simple test for LCC and polar stereographic have been added (cylindrical not included due to a pyproj warning/error; no CF attributes are able to be generated).

Checklist

@jthielen jthielen added Type: Bug Something is not working like it should Area: IO Pertains to reading data Area: Projections Pertains to projecting coordinates between coordinate systems labels Aug 30, 2021
@jthielen jthielen added this to the 1.2.0 milestone Aug 30, 2021
@jthielen jthielen requested a review from a team as a code owner August 30, 2021 20:57
@jthielen jthielen mentioned this pull request Aug 30, 2021
Open
9 tasks
@jthielen
Copy link
Collaborator Author

jthielen commented Sep 1, 2021

Test failure looks to be an inconsistency in pyproj.CRS.to_cf() output given same input with old pyproj. What would the best way to work around this be?

  • skip/xfail on old pyrpoj?
  • bump minimum to oldest consistent version?
  • write version-dependent test?

@dopplershift
Copy link
Member

Well, we can easily bump to 2.4, could consider 2.5 or 2.6--if any of that makes this easier? Otherwise, just skip on old pyproj.

@jthielen
Copy link
Collaborator Author

Bumping to pyproj>=2.5.0 (given that this seems have been the relevant change) has resolved the test consistency issue.

dopplershift
dopplershift approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dopplershift dopplershift merged commit 6607c8d into Unidata:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: IO Pertains to reading data Area: Projections Pertains to projecting coordinates between coordinate systems Type: Bug Something is not working like it should
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

GEMPAK reader assigns grid mapping information incorrectly
2 participants
@jthielen @dopplershift