Fix interpolation with mixed types #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
When given a DataArray and a numpy array, neither with units, a Quantity would be passed into the core calculation, triggering an exception on `apply_along_axis`. Instead, handle trying to convert and drop units on a "dimensionless" Quantity, since that's what we get for a DataArray with no units.
dcamron
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
When given a DataArray and a numpy array, neither with units, a Quantity would be passed into the core calculation, triggering an exception on
apply_along_axis. Instead, handle trying to convert and drop units on a "dimensionless" Quantity, since that's what we get for a DataArray with no units.Checklist