-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update state and county shapefiles #3293
Conversation
Original county files were from the 2016 US Census Bureau collection. The state files were generated separately using the county files, but the geometry was completely topologically equivalent to the US Census Bureau state file collection, so we now use the state collections directly; the metadata (e.g. feature names) were incorrect in our files and are now corrected.
Also set a correct default ellipse for these data, which are on NAD83 rather than WGS84.
We could actually fully automatically generate this, either as a pre-commit hook or as part of building the wheel. Will hold off on those until we are ready to do more.
47c855b
to
72c2e1c
Compare
I added a step to our linting check to make sure the registry ( |
Looks like we'll need some test updates. Seems appropriate to re-generate some of the |
ba01f00
to
b190b32
Compare
The original US state files were generated from dissolving the counties by states using GIS, so that was why they were equivalent and also had not great metadata. I was not able to locate all of the files linked in the description of changes above, so I made my own. This PR is a vast improvement over the original files. |
b190b32
to
d0f3115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me.
Description Of Changes
This started as a way to address warnings I started seeing with GDAL >= 3.7.3:
It turns out these are actually spurious (see OSGeo/gdal#8767) and should be fixed with GDAL >=3.8.1.
In the course of investigating, I found that:
Based on Shapely, it looks like the state borders we had were completely geometrically equivalent to the US Census Bureau state file collection from 2016. Therefore, this updates to use the U.S. state and county shapefiles from the 2022 collection. In the process, a few more files (which are downloaded automatically) are added that include the text encoding as well as a projection (though not yet used by Cartopy SciTools/cartopy#2289); as a result, this also updates the default globe for the feature to use the correct NAD83 rather than WGS84.