Documentation theme updates #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Docs
dcamron
approved these changes
Jan 6, 2025
Use the appropriate version depending on the current dark mode setting.
Replace default secondary color with something that better matches Unidata colors. Also remove and clean up some of the rest of the custom theming, including making dark mode work.
dcamron
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
With the update to 0.16.0 of pydata-sphinx-theme, we're seeing more of the purple color in the docs, specifically mousing over the header links. It turns out this is because "violet" is the default secondary--change that to a teal that better matches "Unidata colors." Also adds a version of the logo on the main page suitable for dark mode, and with these fixes, I think we can make light/dark mode use the "auto" setting.