Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failings of nc_test/run_inmemory.sh #1240

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fix failings of nc_test/run_inmemory.sh #1240

merged 1 commit into from
Jan 2, 2019

Conversation

DennisHeimbigner
Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner commented Dec 5, 2018

re: issue #1233

Changes:

  1. remove exit that was there for testing.
  2. the program tst_open_mem must be netcdf-4 only.
  3. fix some diff problems
    • Change dataset name for tst_inmemory4_create to tst_inmemory4
    • Modify tst_inmemory.c to reorder the variables (somewhat major rewrite)

Minor Unrelated Fixes:

  1. fix comment problem in nc_provenance.h
  2. Fix memory leak in tst_open_mem.c
  3. fix ncdump/bindata.c to properly compile if netcdf4 is disabled.
  4. minor changes to ncgen.l

re: issue #1233

Changes:

1. remove exit that was there for testing.
2. the program tst_open_mem must be netcdf-4 only.
3. fix some diff problems
   - Change dataset name for tst_inmemory4_create to tst_inmemory4
   - Modify tst_inmemory.c to reorder the variables (somewhat major rewrite)

Minor Unrelated Fixes:
1. fix comment problem in nc_provenance.h
2. Fix memory leak in tst_open_mem.c
3. fix ncdump/bindata.c to properly compile if netcdf4 is disabled.
4. minor changes to ncgen.l
@WardF WardF merged commit 30d63bb into master Jan 2, 2019
@DennisHeimbigner DennisHeimbigner deleted the gh1233.dmh branch January 4, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nc_test/run_inmemory.sh has exit in middle of test script
2 participants