Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating readme.md #3055

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

updating readme.md #3055

wants to merge 4 commits into from

Conversation

kisoqual
Copy link

@kisoqual kisoqual commented Oct 2, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kisoqual kisoqual changed the title + website updatng readme.md Oct 2, 2023
makisukurisu
makisukurisu reviewed Feb 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kisoqual @makisukurisu
Update README.md
dc90aa8 
Co-authored-by: Pavlo Pohorieltsev <[email protected]>
@kisoqual kisoqual changed the title updatng readme.md updating readme.md Feb 16, 2024
@kisoqual kisoqual closed this Feb 16, 2024
@kisoqual kisoqual reopened this Feb 16, 2024
kisoqual
kisoqual commented Feb 16, 2024
View reviewed changes
Copy link
Author

@kisoqual kisoqual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it look better

kisoqual

This comment was marked as off-topic.

Sign in to view

@makisukurisu
Copy link
Collaborator

I have made a PR on the fork repository, not to create a duplicate PR in the Unigram repository (silly me 😓)

Basically it updates the README file by doing the following:

  • Removed Direct downloads
  • Removed a link to GitHub pages website
  • Added accessibility explanations for the screenshots (✅ tested, it seems to work properly)
  • Updated the language counter (29 in the current MS Store version)
  • Made a link shortcuts relative (✅ works fine, tested on the forked repository page)
  • Added Windows 11 N mention
  • Removed unnecessary tick-marks for code styled text

P.S. In the commit message itself I have made a few typos, sorry.

A diff that may be applied on this PR is available here:
https://patch-diff.githubusercontent.com/raw/kisoqual/Unigram/pull/1.diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makisukurisu makisukurisu makisukurisu left review comments

@ppOo4321 ppOo4321 ppOo4321 approved these changes

@xximwon xximwon xximwon approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kisoqual @CLAassistant @makisukurisu @xximwon @ppOo4321