Reduce number of queries to preferences db table #1082
Merged
+56
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 81.19% 81.18% -0.02%
==========================================
Files 140 140
Lines 5074 5076 +2
==========================================
+ Hits 4120 4121 +1
- Misses 954 955 +1 ☔ View full report in Codecov by Sentry. |
hmpf
requested changes
Dec 11, 2024
|
hmpf
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #1072 and this PR, a single request to
incidents/lead to 21 (!) queries to theargus_auth_preferencestable 😄. This PR reduces this number by 7 (#1072 takes care of another 12) so that in the end we have only have 2 queries leftpage_sizepreferenceWe could try and limit that further, but I don't think that that's worth the effort. One thing I'm thinking of, is a middleware that grabs all preferences and adds them to the Request, so that views, utils, context processors and others can just read them from there.
Other views also benefit from these PRs, but I don't have numbers for them