-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use keep a changelog categories for towncrier #745
Use keep a changelog categories for towncrier #745
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 79.43% 79.43%
=======================================
Files 73 73
Lines 3608 3608
=======================================
Hits 2866 2866
Misses 742 742 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but pointing out a minor typo in the (old) text.
638a303
to
f090aa1
Compare
|
### Before opening a PR | ||
To be able to automatically produce the changelog for a release a file for each | ||
### Before merging a pull request | ||
To be able to automatically produce the changelog for a release one file for each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"To be able to automatically produce the changelog for a release, one file for each..."
or the pull request number. If we don't want to add a link to the resulting changelog | ||
entry then a `+` followed by a unique short description. | ||
2. The type of the change: we use `security`, `removed`, `deprecated`, `added`, | ||
`changed` and `fixed`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tempting to also have dependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but can't they all be organized into either added
, changed
or removed
? :)
Also adds a few improvements to the towncrier section of the README.