Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keep a changelog categories for towncrier #745

Merged

Conversation

johannaengland
Copy link
Contributor

Also adds a few improvements to the towncrier section of the README.

@johannaengland johannaengland added the documentation Improvements or additions to documentation label Apr 9, 2024
@johannaengland johannaengland self-assigned this Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Test results

     11 files     803 suites   26m 40s ⏱️
   408 tests    407 ✔️   1 💤 0
4 488 runs  4 477 ✔️ 11 💤 0

Results for commit f090aa1.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (05f611f) to head (f090aa1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #745   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          73       73           
  Lines        3608     3608           
=======================================
  Hits         2866     2866           
  Misses        742      742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but pointing out a minor typo in the (old) text.

README.md Outdated Show resolved Hide resolved
@johannaengland johannaengland force-pushed the github/add-towncrier-categories branch from 638a303 to f090aa1 Compare April 9, 2024 13:09
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johannaengland johannaengland merged commit cefcc10 into Uninett:master Apr 9, 2024
9 of 10 checks passed
@johannaengland johannaengland deleted the github/add-towncrier-categories branch April 9, 2024 13:27
### Before opening a PR
To be able to automatically produce the changelog for a release a file for each
### Before merging a pull request
To be able to automatically produce the changelog for a release one file for each
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To be able to automatically produce the changelog for a release, one file for each..."

or the pull request number. If we don't want to add a link to the resulting changelog
entry then a `+` followed by a unique short description.
2. The type of the change: we use `security`, `removed`, `deprecated`, `added`,
`changed` and `fixed`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tempting to also have dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but can't they all be organized into either added, changed or removed? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants