Improve app settings #906
Merged
Improve app settings #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
added
documentation
elfjes
approved these changes
Oct 14, 2024
hmpf
force-pushed
the
improve-app-settings
branch
3 times, most recently
from
77befe7 to
3f04430
Compare
hmpf
force-pushed
the
improve-app-settings
branch
from
3f04430 to
e04f58d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 84.04% 83.69% -0.35%
==========================================
Files 95 95
Lines 4111 4134 +23
==========================================
+ Hits 3455 3460 +5
- Misses 656 674 +18 ☔ View full report in Codecov by Sentry. |
.. and due to this, move the overriding to the end of base settings
.. make sure the examples are valid JSON
hmpf
force-pushed
the
improve-app-settings
branch
from
e04f58d to
b4f15cd
Compare
|
lunkwill42
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new frontend needs different simple settings (like LOGIN_URL) from the old frontend so we need to support that.
We can piggy-back on the (EXTRA|OVERRIDING)_APPS to do this but geant prefers vanilla settings files.
This is an attempt at having our cake and eating it too. Reusing the (EXTRA|OVERRIDING)_APPS-machinery and still making it easy to override everything with separate settings-files.
(This is not the final step in the journey, just an easily reviewable one.)