Add netsnmp-cffi as alternative SNMP trap receiver back-end #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for making an alternative trap back-end based on netsnmp-cffi, this moves the existing module to a submodule that can be selectively imported, just as we did with `zino.snmp`.
This extracts from `zino.trapd.pysnmp_backend` all auxiliary classes and type definitions that are not specific to the PySNMP back-end and moves them to `zino.trapd.base` so they can be re-used by other back-ends.
This changes the `localhost_receiver` fixture to use 1163 as its trap port, and then updates tests that sends external traps to the fixture so that they will use the port assigned to the fixture. This will better enable the test suite to change trap ports dynamically, which might become necessary when running tests for multiple back-ends in the same test session.
A PySNMP-based and a netsnmp-cffi-based `TrapReceiver` implementation will share a lot of common functionality that is unrelated to the specifics of the underlying SNMP libraries. This factors those things out in to a base class that can be common to the implementations, to avoid redundancies.
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Test results2 tests 0 ✅ 2s ⏱️ For more details on these errors, see this check. Results for commit 5665879. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/use-netsnmpy-cffi #395 +/- ##
==============================================================
- Coverage 98.51% 34.32% -64.20%
==============================================================
Files 80 52 -28
Lines 9893 3733 -6160
==============================================================
- Hits 9746 1281 -8465
- Misses 147 2452 +2305 ☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes the trap part of #383. Dependent on #389.
#389 works on its own, without touching the trap implementation. This builds on that to add just the trap implementation, using many of the same refactoring techniques as #3389.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.