-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update SNX exchange and token address #301
Conversation
Deploy preview for uniswap ready! Built with commit aa238a0 |
hi @hav-noms, could you comment on why Etherscan shows the token address you're updating as the 'upgraded token contract'? https://etherscan.io/address/0x3772f9716cf6d7a09ede3587738aa2af5577483a |
I'll jump in here @NoahZinsmeister as @hav-noms is in the APAC timezone. We have a proxy contract for our SNX token: https://etherscan.io/token/0xc011a72400e58ecd99ee497cf89e3775d4bd732f We've tried setting the Proxy contract address to Uniswap in the past but it failed repeatedly and lost funds and no one seems to know why. It's still an open investigation. As I mentioned in #297 (before subsequently closing it as it didn't have the new exchange set up), we upgraded the underlying We are still waiting for Etherscan to process our request to add information and the SNX icon to the The old token address, |
@justinjmoses got it, thanks for the background, makes sense! everything else looks good, just made some successful test swaps. updated SNX will be live on https://beta.uniswap.exchange in a few minutes, and we will merge to production shortly thereafter |
@NoahZinsmeister it looks like prod hasn't been merged yet - mind taking a look? |
whoops, done! #303 |
* update SNX exchange and token address (#301) * update SNX exchange and token address * checksum exchange address * Account improvements (#302) * begin account migration * prep for styling * improve multi-network support allow deprecated window.web3 providers * kill old modal * remove tests * clean up css * Style account modal * kill scss * bug fixes * use suspense for code-splitting and i18n move abis add ENS support to Web3Status * Account modal mobile styles * style tweaks * finalize migration * fix account styling * fix ethereum svg * fixes * Split wallet modal into components * refactor wallet modal and add connect button styles * removing tap highlights fix spacing on some mobile browsers * Styling fixes for account and warning * clean up injected connector logic * remove console * add wrong network copy * restore border radius change wallet logo * various improvements (#313) * add unchecked signer * remove focus underline from tabs * update tokens * remove console log * remove snx for now * make slippage warnings more robust * memo-ize contexts * improve slippage styling * fix warnings + bugs * clear stale network error * Feather icons (#314) * Remove fontawesome * Update new SNX exchange and new token address (#316) * Update new SNX exchange and new token address * remove whitespace * checksum exchange address
* update SNX exchange and token address * checksum exchange address
* update SNX exchange and token address * checksum exchange address
* update SNX exchange and token address (Uniswap#301) * update SNX exchange and token address * checksum exchange address * Account improvements (Uniswap#302) * begin account migration * prep for styling * improve multi-network support allow deprecated window.web3 providers * kill old modal * remove tests * clean up css * Style account modal * kill scss * bug fixes * use suspense for code-splitting and i18n move abis add ENS support to Web3Status * Account modal mobile styles * style tweaks * finalize migration * fix account styling * fix ethereum svg * fixes * Split wallet modal into components * refactor wallet modal and add connect button styles * removing tap highlights fix spacing on some mobile browsers * Styling fixes for account and warning * clean up injected connector logic * remove console * add wrong network copy * restore border radius change wallet logo * various improvements (Uniswap#313) * add unchecked signer * remove focus underline from tabs * update tokens * remove console log * remove snx for now * make slippage warnings more robust * memo-ize contexts * improve slippage styling * fix warnings + bugs * clear stale network error * Feather icons (Uniswap#314) * Remove fontawesome * Update new SNX exchange and new token address (Uniswap#316) * Update new SNX exchange and new token address * remove whitespace * checksum exchange address
* update SNX exchange and token address * checksum exchange address
* update SNX exchange and token address * checksum exchange address
* update SNX exchange and token address (Uniswap#301) * update SNX exchange and token address * checksum exchange address * Account improvements (Uniswap#302) * begin account migration * prep for styling * improve multi-network support allow deprecated window.web3 providers * kill old modal * remove tests * clean up css * Style account modal * kill scss * bug fixes * use suspense for code-splitting and i18n move abis add ENS support to Web3Status * Account modal mobile styles * style tweaks * finalize migration * fix account styling * fix ethereum svg * fixes * Split wallet modal into components * refactor wallet modal and add connect button styles * removing tap highlights fix spacing on some mobile browsers * Styling fixes for account and warning * clean up injected connector logic * remove console * add wrong network copy * restore border radius change wallet logo * various improvements (Uniswap#313) * add unchecked signer * remove focus underline from tabs * update tokens * remove console log * remove snx for now * make slippage warnings more robust * memo-ize contexts * improve slippage styling * fix warnings + bugs * clear stale network error * Feather icons (Uniswap#314) * Remove fontawesome * Update new SNX exchange and new token address (Uniswap#316) * Update new SNX exchange and new token address * remove whitespace * checksum exchange address
No description provided.