Code

Full testing refactor#174

Code

Draft

snreynolds wants to merge 28 commits intoerc721Uniswap/permit2:erc721from full-testing-refactorUniswap/permit2:full-testing-refactorCopy head branch name to clipboard

+2,495-1,678

Commits

Commits on Jan 5, 2023

• allowance & sig transfer tokenId support

  snreynolds

  committed
  9487742

  Copy full SHA for 9487742

Commits on Jan 6, 2023

• file cleanup

  snreynolds

  committed
  b6e89ca

  Copy full SHA for b6e89ca

• include _ERC721 naming

  snreynolds

  committed
  f8f0a19

  Copy full SHA for f8f0a19

Commits on Jan 12, 2023

• rename'

  snreynolds

  committed
  e0c2dbe

  Copy full SHA for e0c2dbe

Commits on Jan 13, 2023

• use tokenId inside allowance mapping, add operator approvals

  snreynolds

  committed
  78bc9bf

  Copy full SHA for 78bc9bf

• try to share unit bitmap tests

  snreynolds

  committed
  3efe5a8

  Copy full SHA for 3efe5a8

• 721 bitmap tests

  snreynolds

  committed
  1ea812c

  Copy full SHA for 1ea812c

• remove comment

  snreynolds

  committed
  57a9ae8

  Copy full SHA for 57a9ae8

• shared allowance test

  snreynolds

  committed
  d68dd54

  Copy full SHA for d68dd54

• base allowance, erc20 passing:

  snreynolds

  committed
  875f6c9

  Copy full SHA for 875f6c9

• partial working refactor

  snreynolds

  committed
  ae055ba

  Copy full SHA for ae055ba

• permit single refactor done

  snreynolds

  committed
  d41aaf2

  Copy full SHA for d41aaf2

• some more refactor compiling

  snreynolds

  committed
  d412d02

  Copy full SHA for d412d02

• gas

  snreynolds

  committed
  6ba10b5

  Copy full SHA for 6ba10b5

• rename

  snreynolds

  committed
  d2f227e

  Copy full SHA for d2f227e

• fix: check current nonce before setting new nonce & expiration

  snreynolds

  committed
  5ff81cc

  Copy full SHA for 5ff81cc

• fix: use owner

  snreynolds

  committed
  96261d0

  Copy full SHA for 96261d0

• fix: nesting logic

  snreynolds

  committed
  6bb7b77

  Copy full SHA for 6bb7b77

Commits on Jan 31, 2023

• comment update

  snreynolds

  committed
  aec2bd8

  Copy full SHA for aec2bd8

• try to share unit bitmap tests

  snreynolds

  committed
  1d45915

  Copy full SHA for 1d45915

• 721 bitmap tests

  snreynolds

  committed
  443c86c

  Copy full SHA for 443c86c

• remove comment

  snreynolds

  committed
  e3d41f2

  Copy full SHA for e3d41f2

• shared allowance test

  snreynolds

  committed
  ed80cdb

  Copy full SHA for ed80cdb

• gas

  snreynolds

  committed
  a377753

  Copy full SHA for a377753

• rebase and cleanup

  snreynolds

  committed
  195c179

  Copy full SHA for 195c179

Commits on Feb 1, 2023

• gas

  snreynolds

  committed
  cce91d8

  Copy full SHA for cce91d8

Commits on Feb 3, 2023

• merge shared unit test changes

  snreynolds

  committed
  01bc01a

  Copy full SHA for 01bc01a

• some shared structure, 721 not workin tho rn

  snreynolds

  committed
  3d90fbf

  Copy full SHA for 3d90fbf