Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log of concrete execution doesn't print exception anymore #870

Closed
Markoutte opened this issue Sep 7, 2022 · 4 comments · Fixed by #902 or #921
Closed

Log of concrete execution doesn't print exception anymore #870

Markoutte opened this issue Sep 7, 2022 · 4 comments · Fixed by #902 or #921
Assignees
Labels
ctg-bug Issue is a bug

Comments

@Markoutte
Copy link
Collaborator

Description

At the moment, logs that are created by concrete execution don't contains printed exception anymore, but have too much info about data transfer between main process and child process.

To Reproduce

  1. Enable logs using ~/.utbot/settings.properties: logConcreteExecutionErrors=true
  2. Run any test generation which leads to concrete execution failure. For example, Concrete execution fails when Fuzzing tries to initialize Date with String #739
  3. Find logs in temp folder: ~\AppData\Local\Temp\UTBot\utbot-childprocess-errors
  4. Open it.

Expected behavior

Log should contain some system information and an exception that is translated into broken test in main process.

Actual behavior

Log contains some child process problem (#848), many lines like this one:

16:59:27.308 | sent cmd: org.utbot.framework.concrete.UtConcreteExecutionResult@2efe6272

and no information about exception.

Additional context

Looks like this behavior was introduces with #748

@korifey korifey moved this to Todo in UTBot Java Sep 7, 2022
@alisevych alisevych added this to the Release preparation milestone Sep 8, 2022
@alisevych alisevych added the ctg-bug Issue is a bug label Sep 8, 2022
@alisevych
Copy link
Member

@Domonion Could you please raise the priority of this issue and consider its fix? It has big testability value. Currently we do not have any information about an error if it's not reproducing. For example: #885 (comment)

@Domonion Domonion moved this from Todo to In Progress in UTBot Java Sep 9, 2022
Domonion added a commit that referenced this issue Sep 9, 2022
1. fix #870
2. fix #848
changed concrete executor process logs: removed kotlin.logs, moved to rd
logging system, overloaded them to write to system.err, adjusted log
level of some messages to clarify log, removed useless schedulers and
some useless code

N.B.: log system will be redesigned with upcoming utbot test generator
process separation! Changes will be reflected on UtBotJava rd wiki page.
@Domonion
Copy link
Collaborator

Domonion commented Sep 9, 2022

Enable logs using ~/.utbot/settings.properties: logConcreteExecutionErrors=true

I was not able to enable logs by gradle props, only in UtSettings

@alisevych
Copy link
Member

@Domonion Please look for the same option in UtSettings - logConcreteExecutionErrors
FYI: All settings that you can set in settings.properties are present in UtSettings.

Domonion added a commit that referenced this issue Sep 12, 2022
[concrete-executor-rd-logs]
1. fix #870
2. fix #848
changed concrete executor process logs: removed kotlin.logs, moved to rd
logging system, overloaded them to write to system.err, adjusted log
level of some messages to clarify log, removed useless schedulers and
some useless code

N.B.: log system will be redesigned with upcoming utbot test generator
process separation! Changes will be reflected on UtBotJava rd wiki page.
Repository owner moved this from In Progress to Done in UTBot Java Sep 12, 2022
@alisevych
Copy link
Member

@Domonion Could you please also filter out trace/debug records as it was discussed on planning?
Now logs weight about 50 MB each.

@alisevych alisevych reopened this Sep 13, 2022
Repository owner moved this from Done to In Progress in UTBot Java Sep 13, 2022
Domonion added a commit that referenced this issue Sep 13, 2022
fixes #870
Moved logs in RuntimeTraceStorage and DynamicClassTransformer to
ChildProcess.kt logging system
Domonion added a commit that referenced this issue Sep 14, 2022
fixes #870
Moved logs in RuntimeTraceStorage and DynamicClassTransformer to
ChildProcess.kt logging system
Domonion added a commit that referenced this issue Sep 14, 2022
[concrete-executor-logs]
fixes #870
Moved logs in RuntimeTraceStorage and DynamicClassTransformer to
ChildProcess.kt logging system
Repository owner moved this from In Progress to Done in UTBot Java Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ctg-bug Issue is a bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants