Incorrect default test root on antlr project #1017 #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for validation message text
Vassiliy-Kudryashov
requested review from
Markoutte
and removed request for
EgorkaKulikov
Markoutte
approved these changes
Oct 27, 2022
…est-root-on-antlr-project
Vassiliy-Kudryashov
deleted the
Vassiliy-Kudryashov/1017-incorrect-default-test-root-on-antlr-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually we should check if 'test root candidate' belongs to any module instead of checking content entry.
As for 'incorrect default test root', please specify correct one. A for me, the best existing was suggested
Fixes #1017
Type of Change
How Has This Been Tested?
Manual Scenario
Just repeat steps from the issue
Checklist (remove irrelevant options):