Handle not-nullable parameters in Kotlin constructors correctly #1336 #1352
+16
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If constructor in Kotlin code has not-nullable reference parameter, compiler adds instructions calling
kotlin/jvm/internal/Intrinsics.checkNotNullParameter
. But in constructor analyzer we accept constructors iff they "contain only statements matching patternthis.a = something
wherea
is an argument of the constructor". Therefore, we need to add exception for calls to the function above. Also, these calls may reorder local variables, so minor changes inindexToField
were neededFixes #1336
Type of Change
How Has This Been Tested?
Manual Scenario
Checked on example from #1336 -- works as expected (but only when settings are Fuzzer 100%, engine creates only tests where parameter is null, which do not pass concrete executor -- see #1257)
Checklist (remove irrelevant options):
This is the author self-check list