Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sarif results minimization #490 #498

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Jul 12, 2022

Description

Minimize the displayed SARIF results.

Now only one result is displayed for one detected error:

image

Fixes #490

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

org.utbot.sarif.SarifReportTest

Manual Scenario

See details in the issue #490

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • Tests that prove my change is effective
  • All tests pass locally with my changes

@mmvpm mmvpm force-pushed the ideaseeker/sarif_results_minimization branch from cd10609 to a55f620 Compare July 12, 2022 08:27
@mmvpm mmvpm self-assigned this Jul 12, 2022
@mmvpm mmvpm requested a review from sergeypospelov July 12, 2022 08:30
Copy link
Member

@sergeypospelov sergeypospelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK, but I'd like to see a little bit more tests. Also maybe add some simple clarifying examples of minimization to the commentaries or even to the documentation? (it's just a suggestion)

@mmvpm mmvpm force-pushed the ideaseeker/sarif_results_minimization branch from dcde22c to c131150 Compare July 12, 2022 14:11
@mmvpm mmvpm enabled auto-merge (squash) July 12, 2022 14:12
@mmvpm mmvpm force-pushed the ideaseeker/sarif_results_minimization branch from c131150 to 587cf11 Compare July 13, 2022 07:05
@mmvpm mmvpm requested a review from sergeypospelov July 13, 2022 08:02
@mmvpm mmvpm merged commit c3dcf29 into main Jul 13, 2022
@mmvpm mmvpm deleted the ideaseeker/sarif_results_minimization branch July 13, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Minimize results in SARIF report
2 participants