Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow in fuzzing #588 #604

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Overflow in fuzzing #588 #604

merged 2 commits into from
Jul 28, 2022

Conversation

Markoutte
Copy link
Collaborator

Description

Overflow occurs in randomizer when fuzzing tries to shuffle values for further processing. The solution is to divide PseudoShuffledIntProgression into parts which can be processed within range 0..Int.MAX_VALUE. It decreases level of how random combinations are, but this is a little trade-off between memory consumption and this level.

Also, CombinationsKt is changed to process up to Long.MAX_VALUE combinations.

Fixes #588

Type of Change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

org.utbot.framework.plugin.api.CombinationsTest
org.utbot.framework.plugin.api.FuzzerTest

Manual Scenario

Verify the origin problem from #588

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@Markoutte Markoutte requested a review from SBOne-Kenobi July 28, 2022 06:53
@Markoutte Markoutte force-pushed the pelevin/588_Overflow_in_fuzzing branch from 8fda135 to 3351aaa Compare July 28, 2022 09:17
@Markoutte Markoutte requested a review from SBOne-Kenobi July 28, 2022 09:20
Copy link
Collaborator

@SBOne-Kenobi SBOne-Kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Markoutte Markoutte merged commit 45b7165 into main Jul 28, 2022
@Markoutte Markoutte deleted the pelevin/588_Overflow_in_fuzzing branch July 28, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Overflow in fuzzing
2 participants