Add support for loading a glTF from an arbitrary stream #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandr01d
changed the title
|
@sandr01d Thanks a lot for this contribution! I've reviewed it and improved it in some aspects internally:
It'll be merged internally and released soon. Again, thanks! |
Needle-Mirror-Bot
pushed a commit
to needle-mirror/com.unity.cloud.gltfast
that referenced
this pull request
Jun 28, 2024
## [6.7.0] - 2024-06-25 ### Added - (Import) Support for [materials variants extension](https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_variants). - Serialization support for material extensions IOR, Sheen and Specular. - (Import) Ability to load a glTF from a generic `Stream` (`GltfImport.LoadStream`; thanks [sandr01d][sandr01d] for [#10](Unity-Technologies/com.unity.cloud.gltfast#10)). ### Changed - (Import) Prefabs imported from glTF assets (at design-time) don't have the glTF logo icon assigned to them anymore. This makes it more consistent with other file types (like FBX; fixes [#557](atteneder/glTFast#557)). ### Deprecated - `MetaMaterialExport`. Always use `MaterialExport.GetDefaultMaterialExport` to get the correct material export. ### Fixed - (Export) glTFast shader based materials and textures are exported correctly when using the default render pipeline. - Added missing entries to the API documentation. - (Export) Base colors are now in correct, linear color space. - Alpha mode blend now works as expected in HDRP 11 and newer as well (fixes [#699](atteneder/glTFast#699)). - (Export) Fixed mesh min/max when using Draco compression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mostly kept the existing implementation of
GltfImport.LoadFile(), but modified it to support any kind of stream (as long as the stream is readable). While loading from a file stream does probably cover most use cases, being able to load from any kind of stream does offer some benefints, e.g. when loading a glTF from a MemoryStream that is already in memory. My personal use case is loading a glTF from a zip archive's DeflateStream directly without having to decrompress the entire file first.There is a slight downside with this new implementation: the parsing of the JSON string can not be cancelled. A override of
StreamReader.ReadToEndAsync()that takes a cancellation token exists in .NET 7, but I guess it will take a while until Unity catches up with that. That being said, I think that shouldn't be an issue, as glTFast parses JSON very fast and we can still cancel before starting to parse binary data.I've originally opened a PR in atteneder#646, but I'm reopening it here since it was suggested to do so in atteneder#650 (comment).