Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct variable names used for initialization (external PR #145) #150

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: correct variable names used for initialization (external PR #145) #150

merged 2 commits into from
Dec 12, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Dec 12, 2023 •
edited
Loading

Description

This is an internal PR that brings along the fix completed in this external PR.
Yamato jobs won't trigger from external PRs, so this is a temporary solution to ensure jobs run on external work.

Here, variable names are swapped for proper initialization.

Issue Number(s)

N/A. Original PR: #145

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez marked this pull request as ready for review December 12, 2023 15:37
@fernando-cortez fernando-cortez requested a review from a team as a code owner December 12, 2023 15:37
jilfranco-unity
jilfranco-unity approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice catch! LGTM

@fernando-cortez fernando-cortez merged commit ca173a7 into develop Dec 12, 2023
@fernando-cortez fernando-cortez deleted the feat/external-PR-145 branch December 12, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilfranco-unity jilfranco-unity jilfranco-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @jilfranco-unity @alexia6119