Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/include ide and remove unused packages [MTT-8034] #166

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Apr 22, 2024

Description

I updated the IDE packages of all Basic Samples.
When it comes to which packages can be removed I am unsure about:

  • Timeline
  • TextMeshPro
  • AI Navigation (Client Driven)

Should these or any other packages be removed? Please let me know.
Also I updated some other packages, please let me know if I should NOT update other packages than the IDE packages.

Issue Number(s)

MTT-8034

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf added the good first issue Good for newcomers label Apr 22, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this Apr 22, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review April 22, 2024 09:28
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner April 22, 2024 09:28
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I updated some other packages, please let me know if I should NOT update other packages than the IDE packages.

You should not. Updating packages is a potential breaking change that is usually done in 2 specific cases:

  1. When the package version you're upgrading to has a fix/feature you need
  2. When the editor forces you (I.E: when upgrading Unity from one version to another)

Can you please revert the changes so that only IDE packages are updated? (you'll need to adjust the changelog entry too)

@Elfi0Kuhndorf
Copy link
Contributor Author

Elfi0Kuhndorf commented Apr 22, 2024

You should not. Updating packages is a potential breaking change

Alright, I was suspecting that, well now I have it confirmed. Thanks!
I will remove the additional package upgrades and adjust the changelog accordingly

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 2c96d62 into develop Apr 23, 2024
19 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the fix/include-ide-and-remove-unused-packages branch April 23, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants