Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distributed authority sample/expanded controls [MTT-9277] #256

Merged

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Nov 15, 2024

Description

This PR adds the skeleton mobile controls UI to the project. Mobile controls can be debugged inside the editor by toggling the following field inside the Bootstrap scene:
Screenshot 2024-11-15 at 16 48 12

A result of this bootstrapping mobile work is that there's a wrapper between the UI and the project's inputs. So, at a high level, UI captures the value of a joystick or a button and routes them to the associated input system action. The result of this is some wrapper Input classes were removed or deprecated, as the game should fetch the input data from the new GameInput class, instead of referencing actions independently. The reason for this is that InputSystemManager now handles what platform the game is on and subsequently what control scheme to be on. Thus, reading from GameInput will track the currently enabled actions.

Note: having a gamepad connected while debugging mobile controls will override both the virtual joystick inputs, so make sure to test gamepad when outside mobile debug mode.

Issue Number(s)

MTT-9277

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez changed the title feat: distributed authority sample/expanded controls [MTT-9278] feat: distributed authority sample/expanded controls [MTT-9277] Nov 15, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review November 18, 2024 20:47
@fernando-cortez fernando-cortez requested a review from a team as a code owner November 18, 2024 20:47
@Elfi0Kuhndorf
Copy link
Contributor

The controller controls work well!

With the mobile ones I have some issues:

  • The jumping is very hard to execute when walking
  • The buttons are too small it is hard to execute them/ not comfortable
  • The interact button was for me in the right upper corner, which is not a good position to execute it, it should be close to the jump button

@fernando-cortez
Copy link
Collaborator Author

The controller controls work well!

With the mobile ones I have some issues:

  • The jumping is very hard to execute when walking
  • The buttons are too small it is hard to execute them/ not comfortable
  • The interact button was for me in the right upper corner, which is not a good position to execute it, it should be close to the jump button

What was challenging about the jumping? Is it something a follow-up PR could address?
If every bullet here could be addressed in a follow-up PR with images/positioning, then I think this one can go through as is.

@Elfi0Kuhndorf
Copy link
Contributor

What was challenging about the jumping? Is it something a follow-up PR could address?

It was hard to actually hit the jump button when walking, it did not execute well for me while I pressed the walking button.

@hammerlerobi
Copy link
Contributor

hammerlerobi commented Nov 27, 2024

Tested on mobile needs some tweaking, but i guess we will have a follow up PR to address the Chat burger button etc.

Elfi0Kuhndorf
Elfi0Kuhndorf previously approved these changes Nov 27, 2024
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framing of the main menu on mobile is not perfect (a bit zoomed out would be better), but otherwise it is good to go. I did not encounter any errors, worked as expected. As discussed the buttons should be adjusted in new PR.

… github.com:Unity-Technologies/com.unity.multiplayer.samples.bitesize into feat/distributed-authority-sample/expanded-controls
hammerlerobi
hammerlerobi previously approved these changes Nov 28, 2024
@hammerlerobi hammerlerobi merged commit 5cf9b2f into develop Dec 2, 2024
8 of 29 checks passed
@hammerlerobi hammerlerobi deleted the feat/distributed-authority-sample/expanded-controls branch December 2, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants