Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Player Colors #75

Merged
merged 10 commits into from
Dec 7, 2022
Merged

Feat: Player Colors #75

merged 10 commits into from
Dec 7, 2022

Conversation

jilfranco-unity
Copy link
Contributor

This PR is for implementing different colors for each player. I've added in a new shader, some new textures, and the implementation of applying a different color for each player.

image

@jilfranco-unity jilfranco-unity added the enhancement New feature or request label Dec 6, 2022
@jilfranco-unity jilfranco-unity marked this pull request as ready for review December 6, 2022 21:00
SamuelBellomo
SamuelBellomo approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but shaders and other should be reviewed by other folks

@jilfranco-unity jilfranco-unity merged commit 2dbe6ef into develop Dec 7, 2022
@jilfranco-unity jilfranco-unity deleted the feat/client-driven-player-colors branch December 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jilfranco-unity @SamuelBellomo