Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing warning when spawning powerups #90

Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix: removing warning when spawning powerups #90

merged 3 commits into from
Jan 4, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jan 4, 2023 •
edited
Loading

Description

This simply moves the update to the powerups' buffType NetworkVariable to after they are spawned to remove the warnings in the console.

Issue Number(s)

None

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@LPLafontaineB LPLafontaineB marked this pull request as ready for review January 4, 2023 18:55
@LPLafontaineB LPLafontaineB added the bug Something isn't working label Jan 4, 2023
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) January 4, 2023 20:39
@LPLafontaineB LPLafontaineB merged commit e50a3d8 into develop Jan 4, 2023
@LPLafontaineB LPLafontaineB deleted the fix/asteroid-spawn-warning branch January 4, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LPLafontaineB @SamuelBellomo