Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the pypiwin32 package #1668

Merged
merged 4 commits into from
Feb 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/Installation-Windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ pip install -e .
This will complete the installation of all the required Python packages to run
the ML-Agents toolkit.

Sometimes on Windows, when you use pip to install certain python packages, the pip will get stuck when trying to read the cache of the package. If you see this, you can try:

```sh
pip install -e . --no-cache-dir
```

This `--no-cache-dir` tells the pip to disable the cache.

## (Optional) Step 4: GPU Training using The ML-Agents Toolkit

GPU is not required for the ML-Agents toolkit and won't speed up the PPO
Expand Down
3 changes: 2 additions & 1 deletion ml-agents/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
'docopt',
'pyyaml',
'protobuf>=3.6,<3.7',
'grpcio>=1.11.0,<1.12.0'],
'grpcio>=1.11.0,<1.12.0',
'pypiwin32==223;platform_system=="Windows"'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested on both Mac and Windows ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I tested this on Mac, Windows and Linux.


python_requires=">=3.6,<3.7",

Expand Down
4 changes: 2 additions & 2 deletions ml-agents/tests/trainers/test_ppo.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ def dummy_config():

@mock.patch('mlagents.envs.UnityEnvironment.executable_launcher')
@mock.patch('mlagents.envs.UnityEnvironment.get_communicator')
def test_ppo_policy_evaluate(mock_communicator, mock_launcher):
def test_ppo_policy_evaluate(mock_communicator, mock_launcher, dummy_config):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on both Windows and Mac ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

tf.reset_default_graph()
mock_communicator.return_value = MockCommunicator(
discrete_action=False, visual_inputs=0)
env = UnityEnvironment(' ')
brain_infos = env.reset()
brain_info = brain_infos[env.brain_names[0]]

trainer_parameters = dummy_config()
trainer_parameters = dummy_config
model_path = env.brain_names[0]
trainer_parameters['model_path'] = model_path
trainer_parameters['keep_checkpoints'] = 3
Expand Down