add pre-commit hook for dotnet-format #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Aug 14, 2020
DevProject/.editorconfig
Outdated
| @@ -0,0 +1 @@ | |||
| com.unity.ml-agents/.editorconfig | |||
There was a problem hiding this comment.
This is a symlink to the "main" config.
chriselion
commented
Aug 14, 2020
| for f in args.files: | ||
| fp.write(f + "\n") | ||
|
|
||
| subprocess_args = ["dotnet", "format", "--folder", "--include", f"@{resp_file}"] |
There was a problem hiding this comment.
Could potentially add more flags here (and in the ArgumentParser accordingly) but this works well enough for now.
added 2 commits
August 14, 2020 11:46
|
Thanks to @tomekpaszek for introducing me to |
surfnerd
approved these changes
Aug 14, 2020
added 7 commits
August 14, 2020 16:10
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
WIP - hook to run dotnet-format on cs files. Assumes the package is already installed.
Will likely fail to start precommit in CI; will definitely fail because files aren't formatted correctly.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments