-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @mdx-js/react to v2 #1322
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/EDiQA4BXEaM3D4rqSceXJhTjBfTU |
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 79083ee |
@thomasheartman I think this fails because the website lock file us not update. Mind take a look? |
@ivarconr Thanks for pinging me! It seems that the Instead, I think this may be because of a breaking change from v1.6.22 to v2.0.0. Looking at the logs, it looks like v2.0.0 changes the package structure:
Also, docusaurus explicitly supports mdx v1, as mentioned in their docs. I don't know if that's related or not, though. I couldn't find any issues on their repo about this. Update: with a liiittle more research (checking out the mdx-js website, I'm more inclined to say that this is a straight update to mdx v2, and thus incompatible with docusaurus (for now). I suggest we close this and ignore this update for now unless you've got other suggestions? Maybe a newer beta version deals with it? |
thanks for showing the error. It fails because @mdx-js/react migrated to ESM modules, currently not used by docusaurus. We can close this for now. |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 2.x releases. However, if you upgrade to 2.x manually then Renovate will reenable minor and patch updates automatically. If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
Got it (and closed). In that case, it probably relates to this issue: |
This PR contains the following updates:
1.6.22
->2.0.0
Release Notes
mdx-js/mdx
v2.0.0
Compare Source
Welcome to MDX 2! See the of the website for everything:
Changelog since last RC
##### `@mdx-js/mdx`4a48f1f
Fix custom elements (#1911)@mdx-js/react
9ca9d40
Fix unnecessary top-level context changes (#1924)@mdx-js/loader
e0b697a
9d5501b
Add improved webpack cache (#1912, #1916)@mdx-js/esbuild
5c61f57
Fix resolve base in esbuild loader (#1854)remark-mdx
a5daaad
Updatemdast-util-mdx
(#1925)Thanks @redallen, @lonyele, @PaulieScanlon, @pd4d10, @Gowee, @mskelton, @ihupoo, @remcohaszing, @loreanvictor, @ChrisChinchilla, @glitteringkatie, @mvasilkov, @jablko, @michaeloliverx, @yordis, @rodrez, @imballinst, @gaearon.
Full Changelog: mdx-js/mdx@v1.6.3...2.0.0
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.