Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新: 更换Economics.Skill延迟计算方式 #462

Merged
merged 12 commits into from
Sep 12, 2024
Merged

Conversation

Controllerdestiny
Copy link
Contributor

详细说明

<-懒得写其实也没事->

PR 自查表

添加插件

  • 插件已加入解决方案 (Plugin.sln)
  • 插件项目已导入template.targets ()
  • 插件信息已加入仓库文档 (README.md)
  • 插件的文件夹名字和插件的插件项目名字一样 (XXX/XXX.csproj)
  • 添加插件单独的README.md文件 (XXX/README.md)
  • 插件可以正常工作

更新插件/修复BUG

  • 插件已修改版本号
  • 更新插件README.md中的更新日志
  • 插件可以正常工作

其他

  • ❤️熙恩我喜欢你

Note

没用的选项自行删掉哦~

@LaoSparrow
Copy link
Member

LaoSparrow commented Sep 10, 2024

schedulers 好像可以换成 key为guid, value 为 scheduler 的dictionary

@Controllerdestiny
Copy link
Contributor Author

schedulers 好像可以换成 key为guid, value 为 scheduler 的dictionary

话说这个换成dictionary有啥说法吗?

@LaoSparrow
Copy link
Member

LaoSparrow commented Sep 10, 2024

schedulers 好像可以换成 key为guid, value 为 scheduler 的dictionary

话说这个换成dictionary有啥说法吗?

从里面删除scheduler的时候能快点,不用遍历
(其实不改也可以,毕竟schedulers元素数量比较小

@Controllerdestiny
Copy link
Contributor Author

schedulers 好像可以换成 key为guid, value 为 scheduler 的dictionary

话说这个换成dictionary有啥说法吗?

从里面删除scheduler的时候能快点,不用遍历 (其实不改也可以,毕竟schedulers元素数量比较小

schedulers 好像可以换成 key为guid, value 为 scheduler 的dictionary

话说这个换成dictionary有啥说法吗?

从里面删除scheduler的时候能快点,不用遍历 (其实不改也可以,毕竟schedulers元素数量比较小

感觉好像没区别,毕竟还是要遍历去检测到没到时间,目前是顺手给删了。

@LaoSparrow
Copy link
Member

草,好像有bug
FrameUpdate 那里会跳过 被移除的scheduler的下一个scheduler
就像这样 (c update后被移除)
ab[c]de -> abd[e]

@LaoSparrow
Copy link
Member

@Controllerdestiny
Copy link
Contributor Author

草,好像有bug FrameUpdate 那里会跳过 被移除的scheduler的下一个scheduler 就像这样 (c update后被移除) ab[c]de -> abd[e]

思考,这个写的时候考虑过,会不会有问题,但运行下来还真没发现问题,不过还是改了。

@Controllerdestiny
Copy link
Contributor Author

草,好像有bug FrameUpdate 那里会跳过 被移除的scheduler的下一个scheduler 就像这样 (c update后被移除) ab[c]de -> abd[e]

搜了下确实有问题

@LaoSparrow
Copy link
Member

草,这样写还不如之前那个,现在每秒新建60个list对象

@Controllerdestiny
Copy link
Contributor Author

草,这样写还不如之前那个,现在每秒新建60个list对象

。。。。

Controllerdestiny added 3 commits September 11, 2024 17:59
@Controllerdestiny Controllerdestiny added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit 481ad3a Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants