Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further AArch64 Support & Syscall OS Nuance Fixes #201

Merged
merged 53 commits into from
Dec 9, 2021

Conversation

FinnWilkinson
Copy link
Contributor

This pull request mainly contains aditional AArch64 instructions (inc. sve) and syscalls needed by the TeaLeaf benchmark (this branch was rebased onto the TeaLeaf-benchmark branch).

There are also some fixes to :

  • Syscall issues that arrose when running SimEng on MacOS as well as Isambard
  • Minor fixex to deal wth sanitizer errors
  • Fixed minor errors that arrose from invalid speculated instructions
  • Ammended SCVTF and FCVT sve implementations and added more relevant test cased

@FinnWilkinson FinnWilkinson added the enhancement New feature or request label Nov 12, 2021
@FinnWilkinson
Copy link
Contributor Author

Faccessat syscall test failing poissibly due to different file structure on Jenkins. Filepath used in test needs re-evaluating and/or print statements need pushing to PR to evaluate where in file directory the tests are being executed from

  • Want test to be relative to the current working directory as we need to test that the use of AT_FDCWD as the dirfd works correctly
  • The current implementation works on my local machine, but was initially failing when executing the tests in different ways due to differing CWD; so the same thing is probably happening on the Jenkins pipeline

@FinnWilkinson
Copy link
Contributor Author

FinnWilkinson commented Nov 26, 2021

No more commits are expected for this PR other than to fix issues brought up when reviewing.

@FinnWilkinson FinnWilkinson linked an issue Nov 26, 2021 that may be closed by this pull request
@FinnWilkinson
Copy link
Contributor Author

#rerun tests

1 similar comment
@jj16791
Copy link
Contributor

jj16791 commented Dec 7, 2021

#rerun tests

…64 syscall so could build SimEng on M1 local machine.
…e. Not needed as following if statement does same check but allows execution to continue if an invalid speculated instruction gets through by returning a dummy value (0).
…tion (32-bit operands) with tests. Also added tests for 32-bit WHILELO sve instruction (64-bit operands).
…ing possible flags for MacOS and Linux in the openat syscall.
FinnWilkinson and others added 27 commits December 9, 2021 10:53
…s retrieved) in attempt to fix jenkins errors.
…y system file structure) by creating a tempory file for the tests, then removing it after the tests have executed.
…different flag. (Tested on system that supports the syscall)
@jj16791 jj16791 force-pushed the MacOS-Syscall-Support branch from ebd2436 to 06ad637 Compare December 9, 2021 10:55
@jj16791 jj16791 merged commit c3bd0c2 into main Dec 9, 2021
@jj16791 jj16791 deleted the MacOS-Syscall-Support branch December 16, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Instruction: NEON movi
2 participants